Skip to content

fix(e2e): stabilize wildcard host DNS test#1144

Merged
drew merged 1 commit intomainfrom
dn/fix-e2e
May 4, 2026
Merged

fix(e2e): stabilize wildcard host DNS test#1144
drew merged 1 commit intomainfrom
dn/fix-e2e

Conversation

@drew
Copy link
Copy Markdown
Collaborator

@drew drew commented May 4, 2026

Summary

Stabilize the Python e2e wildcard-host policy test by replacing the Anthropic telemetry subdomain with deterministic public sslip.io hostnames. The previous statsig.anthropic.com target can be NXDOMAIN or resolve to private ranges in CI, causing the SSRF guard to correctly return 403 before the wildcard match assertion can pass.

Related Issue

N/A

Changes

  • Added shared wildcard test constants backed by 1.1.1.1.sslip.io.
  • Updated host wildcard positive and negative cases to use deterministic public DNS instead of vendor telemetry DNS.
  • Kept the test coverage focused on single-label wildcard matching, bare-domain rejection, and deep-subdomain rejection.

Testing

  • mise run pre-commit passes
  • Unit tests added/updated - not applicable; test-only e2e stabilization
  • E2E tests added/updated - updated the Python e2e wildcard-host coverage, not run locally because no active OPENSHELL_GATEWAY was configured

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable) - not applicable; test-only change

@drew drew requested a review from a team as a code owner May 4, 2026 06:38
@drew drew added the test:e2e Requires end-to-end coverage label May 4, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

Label test:e2e applied for 4eb602e. Open the existing run and click Re-run all jobs to execute with the label set. The E2E Gate check on this PR will flip green automatically once the run finishes.

@drew drew merged commit a255ad9 into main May 4, 2026
56 of 57 checks passed
@drew drew deleted the dn/fix-e2e branch May 4, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test:e2e Requires end-to-end coverage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants