-
Notifications
You must be signed in to change notification settings - Fork 881
feat(l7): add JSON-RPC policy enforcement #1865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
krishicks
wants to merge
35
commits into
main
Choose a base branch
from
hicks/push-nvuozlywzuwu
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
e6bddf3
fix(network): skip no-op startup symlink reloads
krishicks db80648
fix(l7): relay unframed SSE responses
krishicks 4bfe238
test(e2e): add JSON-RPC L7 proxy coverage
krishicks 2a8a261
feat(policy): recognize JSON-RPC L7 endpoints
krishicks 7db5d84
refactor(l7): share HTTP body inspection helper
krishicks 1ce62da
feat(l7): enforce JSON-RPC method rules
krishicks b9bbc2b
fix(l7): honor JSON-RPC body size config
krishicks 7740d91
feat(l7): match JSON-RPC params in rules
krishicks 4f1fbdc
feat(l7): support JSON-RPC batch calls
krishicks 3f237df
fix(l7): redact JSON-RPC params in logs
krishicks 6e2ca22
docs(policy): document JSON-RPC L7 rules
krishicks 8a94b06
fix(sandbox): fail closed on ambiguous JSON-RPC requests
krishicks b69215d
ci(e2e): add MCP conformance coverage
krishicks 47540ad
fix(l7): port JSON-RPC L7 to supervisor network
krishicks fe8b9ec
fix(l7): allow JSON-RPC response messages
krishicks f6fc7ef
fix(policy): require explicit json-rpc rules
krishicks 3a05b68
fix(l7): reject json-rpc response frames
krishicks 86f9a96
ci: harden mcp conformance credentials
krishicks 539627f
docs(policy): clarify json-rpc access rules
krishicks 6173529
test(policy): pin json-rpc rule validation
krishicks 8b9c4ff
fix(l7): harden json-rpc frame handling
krishicks 7dd55c8
refactor(e2e): run MCP conformance runner in a container
krishicks 0702655
refactor(policy): rename JSON-RPC rule method field
krishicks 4d8ed8d
fix(network): hard-deny JSON-RPC response frames in forward proxy
krishicks b1bf4e6
fix(e2e): bind MCP bridge calls to runner capability
krishicks bfe8095
fix(network): require SSE shape for JSON-RPC receive streams
krishicks 14ed51c
fix(lint): Add mcp-conformance Python files
krishicks f16c3c2
fix(e2e): tolerate NAT for MCP bridge callbacks
krishicks 4edf117
test(e2e): add JSON-RPC L7 failure diagnostics
krishicks 1abfcf9
fix(e2e): pass resolved openshell binary to MCP bridge
krishicks 2814a85
fix(l7): keep sparse SSE responses open
krishicks bb1d8ef
fix(e2e): authenticate MCP bridge before body read
krishicks a572b95
docs(e2e): describe MCP bridge NAT tolerance
krishicks 91dac00
ci(e2e): restore host-side registry credentials
krishicks 0c1e237
fix(jsonrpc): allow literal dotted params
krishicks File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For here and other examples, I'd recommend not calling these examples
mcp, because I'm seeing it lead to confusion.It's a valid name, but because it's appears as a root level
yamlobject, and is immediately afterwardsname: mcp, it can lead to some folks considering this to be actual MCP enforcement.Overall, that feels like a larger problem with the YAML syntax, but for this place in particular, it's causing more confusion than it should.