docs: add step for creating the GatewayClass#1984
Merged
Merged
Conversation
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
|
All contributors have signed the DCO ✍️ ✅ |
|
Thank you for your interest in contributing to OpenShell, @zhaohuabing. This project uses a vouch system for first-time contributors. Before submitting a pull request, you need to be vouched by a maintainer. To get vouched:
See CONTRIBUTING.md for details. |
Contributor
Author
|
I have read the DCO document and I hereby sign the DCO. |
Collaborator
|
/ok to test 079963d |
TaylorMutch
approved these changes
Jun 24, 2026
TaylorMutch
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for the fix!
Collaborator
|
Branch check failing is unrelated to your PR |
Contributor
Author
|
Hi @TaylorMutch thanks for the quick response and review on this PR. I really appreciate it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the Kubernetes ingress docs to add a dedicated step for creating the
egGatewayClass that the OpenShell chart references. Previously the docs implied Envoy Gateway registered the GatewayClass automatically, but EG helm chart installs only the CRDs and controller, so the GatewayClass must be created explicitly. Also bumps the Envoy Gateway Helm chart version from v1.7.2 to v1.8.1.Related Issue
N/A — small docs fix.
Changes
gateway.envoyproxy.io/gatewayclass-controllercontrollerTesting
mise run pre-commitpassesChecklist