-
Notifications
You must be signed in to change notification settings - Fork 596
Document environment variables #2552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Kirthi Shankar Sivamani <[email protected]>
Greptile SummaryThis PR adds comprehensive documentation for all environment variables used in Transformer Engine. The new Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant Docs as Documentation Site
participant Index as docs/index.rst
participant EnvVars as docs/envvars.rst
User->>Docs: Navigate to documentation
Docs->>Index: Load index page
Index->>Index: Display "Advanced" section
Note over Index: Added envvars link
User->>Index: Click "Environment Variables"
Index->>EnvVars: Load envvars.rst
EnvVars->>EnvVars: Render RST documentation
Note over EnvVars: Build-Time Variables<br/>Runtime Variables<br/>Examples
EnvVars->>User: Display formatted documentation
Note over User: Can reference 60+ environment<br/>variables with types,<br/>defaults, and examples
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (1)
-
docs/envvars.rst, line 380-399 (link)style: Missing
NVTE_DPA_FP8_RECIPE_DPAandNVTE_DPA_FP8_RECIPE_MHA(used intransformer_engine/pytorch/attention/multi_head_attention.py:42-43). Also missing:NVTE_AG_P2P_MULTI_ATOMIC,NVTE_APPLY_QK_LAYER_SCALING,NVTE_BATCH_MHA_P2P_COMM,NVTE_CUDA_ARCHS, several internal/experimental variables
2 files reviewed, 1 comment
Signed-off-by: Kirthi Shankar Sivamani <[email protected]>
Greptile's behavior is changing!From now on, if a review finishes with no comments, we will not post an additional "statistics" comment to confirm that our review found nothing to comment on. However, you can confirm that we reviewed your changes in the status check section. This feature can be toggled off in your Code Review Settings by deselecting "Create a status check for each PR". |
Signed-off-by: Kirthi Shankar Sivamani <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (1)
-
docs/envvars.rst, line 2 (link)syntax: Copyright year should be 2026 to match other documentation files
2 files reviewed, 1 comment
pggPL
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really nice in HTML, I added some small suggestion to cpu coffloading envvar.
Co-authored-by: Paweł Gadziński <[email protected]> Signed-off-by: Kirthi Shankar Sivamani <[email protected]>
Signed-off-by: Kirthi Shankar Sivamani <[email protected]>
pggPL
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Document all environment variables used in TE.
Type of change
Changes
Document all environment variables used in TE.
Checklist: