Clean up CoCo docs#386
Open
a-mccarthy wants to merge 7 commits intoNVIDIA:mainfrom
Open
Conversation
Signed-off-by: Abigail McCarthy <20771501+a-mccarthy@users.noreply.github.com>
Documentation preview |
There was a problem hiding this comment.
Pull request overview
Updates the Confidential Containers deployment guide to improve readability and add more explicit installation/verification steps for prerequisites and operator setup.
Changes:
- Clarifies prerequisite language (IOMMU kernel args for AMD/Intel, assumptions about familiarity).
- Adds explicit Helm installation command and additional example outputs.
- Improves wording/formatting in node labeling guidance and sample workload step numbering.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+80
to
84
| If the host is not configured or if you are unsure, add the ``amd_iommu=on`` Linux kernel command-line argument for AMD CPUs, or ``intel_iommu=on`` for Intel CPUs. For most Linux distributions, add the argument to the ``/etc/default/grub`` file, for instance: | ||
|
|
||
| ... | ||
| GRUB_CMDLINE_LINUX_DEFAULT="quiet amd_iommu=on modprobe.blacklist=nouveau" | ||
| ... |
There was a problem hiding this comment.
The indented GRUB snippet after "for instance:" is no longer introduced as a literal/code block (the previous "::" was removed). In reStructuredText this will render as a block quote or plain indented text rather than a code sample. Consider restoring the trailing "::" or switching to an explicit ".. code-block::" directive for the GRUB snippet.
Signed-off-by: Abigail McCarthy <20771501+a-mccarthy@users.noreply.github.com>
Signed-off-by: Abigail McCarthy <20771501+a-mccarthy@users.noreply.github.com>
dcmiddle
reviewed
May 1, 2026
Signed-off-by: Abigail McCarthy <20771501+a-mccarthy@users.noreply.github.com>
Signed-off-by: Abigail McCarthy <20771501+a-mccarthy@users.noreply.github.com>
Signed-off-by: Abigail McCarthy <20771501+a-mccarthy@users.noreply.github.com>
Signed-off-by: Abigail McCarthy <20771501+a-mccarthy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.