Fix #2027: Remove StridedMemoryView etc. from public API#2028
Merged
leofang merged 10 commits intoNVIDIA:mainfrom May 6, 2026
Merged
Fix #2027: Remove StridedMemoryView etc. from public API#2028leofang merged 10 commits intoNVIDIA:mainfrom
leofang merged 10 commits intoNVIDIA:mainfrom
Conversation
mdboom
added
breaking
rparolin
approved these changes
May 5, 2026
This comment has been minimized.
This comment has been minimized.
leofang
reviewed
May 5, 2026
leofang
reviewed
May 5, 2026
Co-authored-by: Leo Fang <leof@nvidia.com>
Co-authored-by: Leo Fang <leof@nvidia.com>
Contributor
Author
leofang
reviewed
May 6, 2026
| :template: autosummary/cyclass.rst | ||
|
|
||
| StridedMemoryView | ||
| cuda.core.utils.StridedMemoryView |
Member
There was a problem hiding this comment.
How about this?
Suggested change
| cuda.core.utils.StridedMemoryView | |
| utils.StridedMemoryView |
and we remove line 282 (.. module:: cuda.core.utils).
leofang
reviewed
May 6, 2026
| :toctree: generated/ | ||
|
|
||
| args_viewable_as_strided_memory | ||
| cuda.core.utils.args_viewable_as_strided_memory |
Member
There was a problem hiding this comment.
Suggested change
| cuda.core.utils.args_viewable_as_strided_memory | |
| utils.args_viewable_as_strided_memory |
leofang
approved these changes
May 6, 2026
Comment on lines
+128
to
+131
| - :func:`args_viewable_as_strided_memory` and :class:`StridedMemoryView` are now | ||
| longer at the top-level in :mod:`cuda.core`. They are available publicly from the | ||
| :mod:`cuda.core.utils` module. | ||
| (`#2028 <https://github.com/NVIDIA/cuda-python/issues/2028>`__) |
Member
There was a problem hiding this comment.
FWIW they were always meant to be available via utils, it seems we slipped in the v0.4 - v0.5 timeframe.
Member
|
LGTM, thanks Mike! |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.