-
Notifications
You must be signed in to change notification settings - Fork 322
Test using pytest-run-parallel and related fixups in the tests #2194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
seberg
wants to merge
21
commits into
NVIDIA:main
Choose a base branch
from
seberg:ft-testing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
f80b699
DEV: run_tests.sh uses pytest-run-parllel and install it on 3.14t and…
seberg 57d9cc2
TST: Mark tests as thread-unsafe or limit the number of threads
seberg 3e95a8c
TST: use tmp_path fixture in cufile (and mark some as unsafe)
seberg 21d0506
TST: Move graph definnitions inline and mark "global" ones as thread-…
seberg da45482
TST: Fixup memory tests, mostly work around issue when tearing down m…
seberg b32f61a
TST: Thread unsafe markers for test_managed_ops
seberg 7e9b64d
Avoid interactive backend when using run_tests.sh locally
seberg 9c7e28d
Use indirect fixtures for a nicer pattern and avoid thread issues
seberg d076620
Make latch-kernel helper compile only once
seberg d50a0e5
Install pytest-run-parallel explicitly in CI
seberg 4224a02
Move pytest-run-parallel setup (and hopefully actually make it work)
seberg b64e723
Limit threads for event test that otherwise seems to ptentially fail
seberg 1b74b22
TST: Mark device-persistence-mode test as thread-unsafe
seberg caaf4ce
Add identity preserving pattern to critical_sections
seberg 1454622
TST: Test fails in CI, assume that few enough threads eventually pass...
seberg dd3459d
TST: Add another sync to guard against potential deadlocks (seems I m…
seberg eea3294
TST: Limit threads for another LatchKernel test
seberg faf1d45
TST: Force test_helpers to single threaded on windows to avoid crash
seberg 5aa94f4
TST: Many buffer related tests cannot run threaded on windows
seberg 8bf484d
These tests seem to test process global cleanup (not sure I follow)
seberg 240d6c4
TST: Mark LatchKernel tests as thread-unsafe
seberg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add this to the test groups in the normal places under
cuda_{bindings,core,pathfinder}/pyproject.toml?