Add check for pre-release generated content - #2373
Conversation
|
|
This check can silently miss pre-release content:
Could we support both current header formats and add focused tests for each, plus the unrecognized-header case? |
|
@mdboom I looked more closely, I believe these are the only essential changes in scope for this PR:
The second format is used by six files: driver, runtime, and nvrtc, each as .pyx and .pxd. (This is also exactly Andy’s first point, and what I shared earlier offline.)
If it's not easy to add CTK metadata to those files, it would seem OK to explicitly exempt them, but to reject every other sealed file with zero, multiple, or unrecognized version headers. That accommodates the status quo while also ensuring that future generator-format drift fails loudly. — I believe this is also exactly Andy's second point. |
This is a good call-out that we are missing this information in docs. Those need to be checked as well (because they would leak info about new APIs). I will fix that on the generator side and then plug that hole here. |
|
We need generator MR 497 to be merged first, generate its changes here, and then this check should be complete and work. |
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Now that our generator behaves differently, this is an extra check for pre-release content.