New lowpp layer for nvrtc#2398
Merged
Merged
Conversation
github-actions
Bot
added
cuda.bindings
This comment has been minimized.
This comment has been minimized.
mdboom
commented
Jul 22, 2026
isVoid
self-requested a review
July 22, 2026 19:25
isVoid
approved these changes
Jul 22, 2026
mdboom
marked this pull request as draft
July 22, 2026 21:03
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
Thanks for the review, @isVoid. Marking as draft so we don't accidentally merge this until the generator-side is merged. |
mdboom
marked this pull request as ready for review
July 22, 2026 21:07
mdboom
enabled auto-merge (squash)
July 22, 2026 21:07
mdboom
added
enhancement
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new modern-generated version of the lowpp layer for nvrtc, and then updates all library code to use it.
As per the design document, this lands as
cuda.bindings._v2.nvrtc, and then will be moved tocuda.bindings.v2.nvrtconce we are comfortable the API is stable.The test update procedure is:
nvrtcas-is to a newlegacy_testsdirectory (and pytest also requires that we rename the file).We should also disallow the use of the legacy API in the non-legacy_tests directory. That's currently blocked on #2384, so I created #2397 to follow-up on that later.
====
Porting cuda_core to use these new APIs will need to be follow-on work. Our dependency specs say that cuda_core has to work with older cuda_bindings, and of course they don't have this new API yet. So we will need to stage that appropriately.