Allow NULL dlpack deleter and no version in interfaces - #2427
Merged
Conversation
Technically a dlpack deleter is allowed to be NULL, the `.get()` seemed like a harmless change so I did it, but also doesn't really matter. But trying to add a test for the `.get()` I noticed that there seemed quite a bit of duplication so the biggest change here is test deduplication...
seberg
added
bug
mdboom
approved these changes
Jul 27, 2026
seberg
enabled auto-merge (squash)
July 27, 2026 14:48
This comment has been minimized.
This comment has been minimized.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Technically a dlpack deleter is allowed to be NULL, the
.get()seemed like a harmless change so I did it, but also doesn't really matter.But trying to add a test for the
.get()I noticed that there seemed quite a bit of duplication so the biggest change here is test deduplication...Checklist