fix(helm): grant carbide-api 'get services' RBAC for DPF BFB URL lookup#1316
Closed
chet wants to merge 1 commit into
Closed
fix(helm): grant carbide-api 'get services' RBAC for DPF BFB URL lookup#1316chet wants to merge 1 commit into
chet wants to merge 1 commit into
Conversation
This is needed when DPF v1 is enabled and a static `dpf.bfb_url` isn't configured (meaning dpf::resolve_bfb_url tries to read the `carbide-pxe-external` Service IP to build a URL). Without this rule, carbide-api will fail with a 403 from the k8s apiserver. Fwiw, it might not even be needed, since this is v1 only, but wanted to put a PR up just incase. Happy to close it out if it's useless now! Signed-off-by: Chet Nichols III <chetn@nvidia.com>
ianderson-nvidia
approved these changes
May 5, 2026
Contributor
|
This is not needed now. We have moved from the carbide bfb to vanilla bfb completely. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is needed when DPF v1 is enabled and a static
dpf.bfb_urlisn't configured (meaning dpf::resolve_bfb_url tries to read thecarbide-pxe-externalService IP to build a URL). Without this rule, carbide-api will fail with a 403 from the k8s apiserver.Fwiw, it might not even be needed, since this is v1 only (and we're going to be going to v2 now anyway), BUT, wanted to put a PR up just incase. Happy to close it out if it's useless now!
Signed-off-by: Chet Nichols III chetn@nvidia.com
Type of Change
Related Issues (Optional)
Breaking Changes
Testing
Additional Notes