Skip to content

fix(components): replace eval() with ast.literal_eval() for safe metadata parsing #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janickm merged 1 commit into from
May 15, 2026
Merged

fix(components): replace eval() with ast.literal_eval() for safe metadata parsing #113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ncore/impl/data/v4/components.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

from __future__ import annotations

import ast
import concurrent.futures
import io
import json
Expand Down Expand Up @@ -833,7 +834,7 @@ def get_static_poses(self) -> Generator[Tuple[Tuple[str, str], npt.NDArray[np.fl
"""Returns all static poses (rigid transformations) between named coordinate frames, if available"""

for key, static_pose in self._group["static_poses"].attrs.items():
yield eval(key), np.array(static_pose["pose"], dtype=static_pose["dtype"])
yield ast.literal_eval(key), np.array(static_pose["pose"], dtype=static_pose["dtype"])

def get_dynamic_poses(
self,
Expand All @@ -842,7 +843,7 @@ def get_dynamic_poses(

for key, dynamic_poses in self._group["dynamic_poses"].attrs.items():
yield (
eval(key),
ast.literal_eval(key),
(
np.array(dynamic_poses["poses"], dtype=dynamic_poses["dtype"]),
np.array(dynamic_poses["timestamps_us"], dtype=np.uint64),
Expand Down
Loading