feat(deps): make torch an optional dependency, only required for sensor evaluation#116
Closed
janickm wants to merge 1 commit into
Closed
feat(deps): make torch an optional dependency, only required for sensor evaluation#116janickm wants to merge 1 commit into
janickm wants to merge 1 commit into
Conversation
61c2eb9 to
298f045
Compare
Collaborator
Author
|
/ok to test 298f045 |
298f045 to
476b9b0
Compare
476b9b0 to
de720d9
Compare
Collaborator
Author
|
/ok to test de720d9 |
Collaborator
Author
|
Postponed -- needs more design work around packaging boundaries before making torch optional. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
torchan optional dependency -- users who only need data reading (ncore.data) no longer need PyTorch installedncore.sensorsnow uses lazy imports via__getattr__, importing torch only when a sensor class is accessedImportErrormessage guides users to installncore[sensors]if torch is missingrequirestoextra_requires = {"sensors": ["torch"]}