Skip to content

feat(deps): make torch an optional dependency, only required for sensor evaluation#116

Closed
janickm wants to merge 1 commit into
NVIDIA:mainfrom
janickm:dev/janickm/optional-torch-dependency
Closed

feat(deps): make torch an optional dependency, only required for sensor evaluation#116
janickm wants to merge 1 commit into
NVIDIA:mainfrom
janickm:dev/janickm/optional-torch-dependency

Conversation

@janickm
Copy link
Copy Markdown
Collaborator

@janickm janickm commented May 15, 2026

Summary

  • Make torch an optional dependency -- users who only need data reading (ncore.data) no longer need PyTorch installed
  • ncore.sensors now uses lazy imports via __getattr__, importing torch only when a sensor class is accessed
  • Clear ImportError message guides users to install ncore[sensors] if torch is missing
  • Wheel updated: torch moved from requires to extra_requires = {"sensors": ["torch"]}
  • All data tests pass without torch at import time; all sensor tests pass with torch available

@janickm janickm self-assigned this May 15, 2026
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 15, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@janickm janickm force-pushed the dev/janickm/optional-torch-dependency branch from 61c2eb9 to 298f045 Compare May 15, 2026 09:49
@janickm
Copy link
Copy Markdown
Collaborator Author

janickm commented May 15, 2026

/ok to test 298f045

@janickm janickm force-pushed the dev/janickm/optional-torch-dependency branch from 298f045 to 476b9b0 Compare May 15, 2026 11:10
@janickm janickm force-pushed the dev/janickm/optional-torch-dependency branch from 476b9b0 to de720d9 Compare May 15, 2026 11:38
@janickm
Copy link
Copy Markdown
Collaborator Author

janickm commented May 15, 2026

/ok to test de720d9

@janickm
Copy link
Copy Markdown
Collaborator Author

janickm commented May 15, 2026

Postponed -- needs more design work around packaging boundaries before making torch optional.

@janickm janickm closed this May 15, 2026
@janickm janickm deleted the dev/janickm/optional-torch-dependency branch May 18, 2026 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant