Skip to content

refactor(sensors): extract shared rolling-shutter iteration logic into common utility#119

Open
janickm wants to merge 1 commit into
NVIDIA:mainfrom
janickm:dev/janickm/refactor-rolling-shutter
Open

refactor(sensors): extract shared rolling-shutter iteration logic into common utility#119
janickm wants to merge 1 commit into
NVIDIA:mainfrom
janickm:dev/janickm/refactor-rolling-shutter

Conversation

@janickm
Copy link
Copy Markdown
Collaborator

@janickm janickm commented May 15, 2026

Summary

  • Extract nearly-identical rolling-shutter iterative solver logic from camera.py and lidar.py into shared utility in common.py
  • New rolling_shutter_iterate() function handles pose interpolation, convergence checking, and iteration loop
  • Camera and lidar pass sensor-specific callbacks (projection, time computation, convergence metric, state update)
  • Pure refactor -- no behavioral changes, all existing sensor tests pass on both Python 3.8 and 3.11

@janickm janickm self-assigned this May 15, 2026
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 15, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@janickm janickm force-pushed the dev/janickm/refactor-rolling-shutter branch from 1af9302 to cca63ca Compare May 15, 2026 09:49
@janickm
Copy link
Copy Markdown
Collaborator Author

janickm commented May 15, 2026

/ok to test cca63ca

@janickm janickm force-pushed the dev/janickm/refactor-rolling-shutter branch 2 times, most recently from c5b66b8 to 9eace52 Compare May 15, 2026 12:20
@janickm
Copy link
Copy Markdown
Collaborator Author

janickm commented May 15, 2026

/ok to test 9eace52

@janickm janickm force-pushed the dev/janickm/refactor-rolling-shutter branch from 9eace52 to f8ea4db Compare May 15, 2026 12:47
@janickm
Copy link
Copy Markdown
Collaborator Author

janickm commented May 15, 2026

/ok to test f8ea4db

@janickm janickm force-pushed the dev/janickm/refactor-rolling-shutter branch from f8ea4db to 7312ea4 Compare May 15, 2026 13:54
@janickm
Copy link
Copy Markdown
Collaborator Author

janickm commented May 15, 2026

/ok to test 7312ea4

@janickm janickm force-pushed the dev/janickm/refactor-rolling-shutter branch from 7312ea4 to 5394266 Compare May 15, 2026 13:57
@janickm
Copy link
Copy Markdown
Collaborator Author

janickm commented May 15, 2026

/ok to test 5394266

@janickm janickm force-pushed the dev/janickm/refactor-rolling-shutter branch from 5394266 to 4c6c7a9 Compare May 15, 2026 14:26
@janickm
Copy link
Copy Markdown
Collaborator Author

janickm commented May 15, 2026

/ok to test 4c6c7a9

@janickm janickm force-pushed the dev/janickm/refactor-rolling-shutter branch from 4c6c7a9 to cbf2cfc Compare May 18, 2026 08:22
@janickm janickm force-pushed the dev/janickm/refactor-rolling-shutter branch from cbf2cfc to 716637d Compare May 19, 2026 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant