feat: add CameraLabelsComponent for typed per-camera image labels#84
Open
janickm wants to merge 3 commits intoNVIDIA:mainfrom
Open
feat: add CameraLabelsComponent for typed per-camera image labels#84janickm wants to merge 3 commits intoNVIDIA:mainfrom
janickm wants to merge 3 commits intoNVIDIA:mainfrom
Conversation
d764527 to
545a6d5
Compare
ebb0949 to
91a6e50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a new V4
CameraLabelsComponentfor storing per-camera image-aligned labels (depth maps, optical flow, segmentation masks, surface normals, etc.) with typed, schema-validated storage.LabelCategoryenum (DEPTH, FLOW, SEGMENTATION, MASK, GEOMETRY, MATERIAL, FEATURE, OTHER) + free-form qualifier string. New label variants require zero code changes.CameraLabelsProtocol,CameraLabelsub-protocol,query_camera_labels(camera_id, label_type?, label_category?).Commits
CameraLabelsComponent with tagged-union type system, compat layer, and tests — Core implementation:
LabelCategory,LabelType(category, qualifier, unit),CameraLabelDescriptor,LabelSchema,CameraLabelsComponent(Writer/Reader),CameraLabelsProtocol,CameraLabelprotocol,SequenceLoaderV4integration,ComponentGroupAssignmentsextension, 12 round-trip tests.Migrate Waymo panoptic segmentation from
generic_datatoCameraLabelsComponent— First real-world usage: Waymo converter now storespanoptic_label_pngasSEGMENTATION/"panoptic"with IMAGE_ENCODED/png encoding. Per-label metadata carries thepanoptic_label_divisor. Class-ID map moved from camera sensor metadata to label component metadata.Add camera label overlay support to ncore_vis — CameraComponent gains a "Camera Labels" overlay option with label source dropdown, opacity slider, and replace-image toggle. Category-aware rendering: depth (TURBO colormap), segmentation (20-color palette), masks (green tint), geometry/normals (RGB mapping), generic (grayscale).
Design
See Camera Labels Component Design wiki page for full design spec including dataverse, sauron, and NRE compatibility tables.
Files Changed
ncore/impl/data/types.pyncore/impl/data/v4/components.pyncore/impl/data/compat.py,ncore/impl/data/v4/compat.pyncore/impl/data/v4/types.pyncore/data/__init__.py,ncore/data/v4/__init__.pyncore/impl/data/v4/components_test.pytools/data_converter/waymo/converter.pytools/ncore_vis/components/camera.py,tools/ncore_vis/data_loader.pytools/data_converter/{colmap,pai}/converter.py(addedcamera_labels_ids=[])