Bootstrap 5 - new#174
Open
dahyehayley wants to merge 7 commits into
Open
Conversation
…elated to c3 change) fix bug - import bootstrap4 artifacts updated css,ts,package-lock.json through npm build and django-vite
Functional:
- data-target/data-parent -> data-bs-target/data-bs-parent (navbars, project_list accordion)
- migrate $.modal('show'/'toggle') to bootstrap.Modal API in allocation_create
- expose bootstrap on window for inline scripts
- remove dead $('[data-toggle="popover"]').popover() (handled by bs.ts)
- restore filter +/- icon swap via shown/hidden.bs.collapse events
- drop unused initCollapse from bs.ts
Styling:
- add text-dark to bg-warning/bg-light/bg-info badges (BS5 defaults to white text)
- ml-*/mr-* -> ms-*/me-* directional spacing
- form-inline/form-group -> d-flex + mb-* utilities
- bg-pill -> rounded-pill; drop dead btn-block
- restore BS4 hover-underline and table cell padding in portal.scss
2. Stlying fix - Margin fix bs4 -> bs5 - fix navbar active highlight and hover underline
Author
|
Unathorized home page Login page Authorized home page Project page Allocation page Center summary page Admin home page |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.