fix(nix): remove unmaintained snowfall-lib dep and improve packaging#459
Open
PlasmaPower wants to merge 1 commit intoNano-Collective:mainfrom
Open
fix(nix): remove unmaintained snowfall-lib dep and improve packaging#459PlasmaPower wants to merge 1 commit intoNano-Collective:mainfrom
PlasmaPower wants to merge 1 commit intoNano-Collective:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I removed the unmaintained
snowfall-libfrom theflake.nixas its last release was in 2024 and it's now producing warnings abut using the deprecatedsystemconfig attribute when built with new nixpkgs versions.While I was at it, I also simplified the nix setup to just put the package in
flake.nix, and I replaced the customscripts/update-nix-version.shwith the standardnix-updatetool.cc @p0ryae since I saw you recently worked on the nix setup in #454. I saw on that PR a comment recommending the prompts cp be replaced with install, but I don't think that works as
installdoesn't support recursive copying.Type of Change
Testing
Automated Tests
There's no relevant new automated tests here. I've made sure to preserve the update-nix workflow checking that the nix build works by passing
--buildtonix-update..spec.ts/tsxfilespnpm test:allcompletes successfully)Manual Testing
I tested that basic functionality works with
nix run ., andnix flake checkpasses. I wasn't able to test the GitHub Actions flow locally, but the changes there seem straightforward and I tested thenix run nixpkgs#nix-update ...command myself.Checklist