fix(android): align drawer icon with top app bar - #82
Open
jsdatarocks wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
Vertically aligns the Android drawer icon with the top app bar by increasing its top padding from
4.dpto8.dp.This complements the navigation slot reservation introduced by NativePHP/mobile-ui#81: that change prevents the navigation title from overlapping the drawer icon, while this change centers the icon within the top app bar.
Problem
On Android, the drawer icon is rendered as a top-left overlay by
NativeLayoutDrawerHost. After applying the status bar inset, the existing4.dptop padding positions the icon slightly above the top app bar's visual center.The horizontal position is already correct, but the vertical offset makes the drawer icon appear misaligned relative to the navigation title and trailing actions.
Changes
4.dpto8.dpon Android.4.dpstart padding unchanged.Dependency and rollout
This is a self-contained layout adjustment and introduces no new API or dependency requirements.
It complements NativePHP/mobile-ui#81 and its companion NativePHP/mobile-air#404, but does not depend on their new registration API and can be reviewed independently.
For end-to-end verification of the complete drawer navigation bar layout, test this change together with those PRs.
Testing
This change only adjusts a Compose layout constant and has no automated behavioral coverage.
It should be manually verified on Android with:
modalandrevealdrawer variants.Confirm that the drawer icon is vertically centered with the navigation title and trailing actions, remains correctly inset from the status bar, and still opens the drawer normally.