Respect runtime appearance overrides in Android renderers - #84
Closed
jeremyfrancis55 wants to merge 1 commit into
Closed
Respect runtime appearance overrides in Android renderers#84jeremyfrancis55 wants to merge 1 commit into
jeremyfrancis55 wants to merge 1 commit into
Conversation
Author
|
I realized I can just store the logged in credentials in secure storage.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isSystemInDarkTheme()reads across Android native UI renderersNativeAppearanceStatesupplied by NativePHP coreProblem
The core Material theme and node backgrounds can recompose for a runtime light/dark override, but individual plugin renderers still read only the device-wide mode. That leaves text, icons, inputs, buttons, dialogs, and other controls in the old palette unless Android recreates the activity. Activity recreation restarts the NativePHP host and can clear an authenticated runtime session.
Using the shared snapshot state makes every renderer update in place without an activity relaunch.
Dependency
Requires NativePHP/mobile-air#412: NativePHP/mobile-air#412
Testing
:app:assembleDebug: pass in a NativePHP app with both changes