feat: add Android emulator boot args support#75
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@DjDeveloperr if not existing (dont think it is ) could we extend this so that we can define those args/options through a config file in .simdeck ? |
|
@farfromrefug Yes we can add it! Not entirely sure about what else we can include there yet. And I assume we would want this file to be persisted right? Since the launch config is relevant for the kind of env the app is to be tested in? Maybe there is more stuff we can put in there too |
|
@DjDeveloperr we could add the port config? Right now i run simdeck from the command line. But i guess at the end we want it running on login possibly? being able to define the port in the config then makes sense BTW i tested with latest changes and i still cant get the websocket to work on my linux. Not sure you fixed it , just wanted to let you know |
|
There is already run at login LaunchAgent for macOS, not sure about Linux. I'm going to setup a Linux and Windows dev environment today to properly test and fix Linux and Windows support locally Ideally, port shouldn't have to be configured. There's only one SimDeck service that should be running and maybe for that we can add a global ~/.simdeck/config.json |
Summary
androidEmulatorArgssupport to SimDeck boot requests and CLI forwarding for Android emulatorsTesting