Skip to content

feat: add Android emulator boot args support#75

Open
DjDeveloperr wants to merge 1 commit into
mainfrom
investigate-issue-73
Open

feat: add Android emulator boot args support#75
DjDeveloperr wants to merge 1 commit into
mainfrom
investigate-issue-73

Conversation

@DjDeveloperr
Copy link
Copy Markdown
Collaborator

Summary

  • Add androidEmulatorArgs support to SimDeck boot requests and CLI forwarding for Android emulators
  • Preserve SimDeck-owned emulator flags while allowing user-supplied startup args
  • Document the new CLI, REST, and GitHub Actions inputs across the repo
  • Update client and test bindings to pass Android boot options through the API

Testing

  • Added unit tests for Android boot argument parsing and request body handling
  • Added client and GitHub Actions coverage for forwarding emulator startup args
  • Not run (not requested)

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 1, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7bab7b03-cc16-4a2b-aa0a-3a416548e70c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch investigate-issue-73

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@farfromrefug
Copy link
Copy Markdown
Contributor

@DjDeveloperr if not existing (dont think it is ) could we extend this so that we can define those args/options through a config file in .simdeck ?

@DjDeveloperr
Copy link
Copy Markdown
Collaborator Author

@farfromrefug Yes we can add it! Not entirely sure about what else we can include there yet. And I assume we would want this file to be persisted right? Since the launch config is relevant for the kind of env the app is to be tested in? Maybe there is more stuff we can put in there too

@farfromrefug
Copy link
Copy Markdown
Contributor

@DjDeveloperr we could add the port config? Right now i run simdeck from the command line. But i guess at the end we want it running on login possibly? being able to define the port in the config then makes sense
And yes it would need to be persisted.
i am thinking we could also have an option to disable audio completely. And by that passing the -no-audio to the android emulator. It is know to create issue with system audio because it is like having a mic constantly "on".
Also i was looking at .simdeck folder. I think server.json should be .server.json to be hidden and to not let user think it could be modified

BTW i tested with latest changes and i still cant get the websocket to work on my linux. Not sure you fixed it , just wanted to let you know

@DjDeveloperr
Copy link
Copy Markdown
Collaborator Author

There is already run at login LaunchAgent for macOS, not sure about Linux. I'm going to setup a Linux and Windows dev environment today to properly test and fix Linux and Windows support locally

Ideally, port shouldn't have to be configured. There's only one SimDeck service that should be running and maybe for that we can add a global ~/.simdeck/config.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants