Feature/addon root layout - #179
Open
orren5 wants to merge 5 commits into
Open
Conversation
Home Assistant's Supervisor only discovers add-ons in top-level directories of a repository (each containing a config.yaml). Nested under "Home Assistant/addon/pi_somfy", this add-on was invisible when adding this repo as an add-on repository via URL — only a manual folder copy worked. Move it to somfy-ha-addon/ at the root and update the README/build.sh references accordingly. The add-on's own slug (pi_somfy) is unrelated to the folder name and is left unchanged.
HACS requires an "integration" repository to have custom_components/<domain> directly at the repo root (unless zip_release/content_in_root is configured in hacs.json, which this repo doesn't use). Nested under "Home Assistant/custom_components/pi_somfy", the structure fails HACS's compliance check — reported as "Repository structure for v3.2 is not compliant" when adding the repo. Move it to custom_components/pi_somfy/ and update the README reference. Note: this only fixes the layout going forward. The v3.2 tag already points at the old nested structure, so a new release will need to be cut after this merges for HACS to see a compliant version.
One-click "Open your Home Assistant instance" badge for adding this repo as a HACS custom repository, alongside the existing manual steps.
Home Assistant Supervisor (add-ons, now called "apps") requires a repository.yaml at the repo root to recognize it as a valid app repository at all — independent of whether an app folder exists at the root. Without it, adding this repo's URL in Settings → Add-ons → Add-on Store → Repositories fails with "not a valid app repository", even once somfy-ha-addon/ is present at the root.
Brings this branch's somfy-ha-addon/ up to date with all of feature/mqtt-ha-config's work, since the two are meant to merge together (this branch gets the add-on discoverable via the standard repository install flow; the other adds MQTT auto-discovery support). - Optional MQTT bridge via a new enable_mqtt toggle, pulling broker details from the Supervisor mqtt service (e.g. Mosquitto add-on) rather than asking the user to re-enter them. - EnableDiscovery + missing-[MQTT]-section guard, translations/en.yaml labels for every option, and a DOCS.md note on external brokers (review feedback from PR Nickduino#178). - Fixed config.yaml's version being "3.0.0", which isn't a real upstream Pi-Somfy tag and broke the Dockerfile's source clone. build.sh now reads the version from config.yaml instead of a second hardcoded copy. - CHANGELOG.md rewritten with real, user-facing release notes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make repo discoverable as an HA add-on/app and HACS repository
Home Assistant's Supervisor only discovers add-ons ("apps") and HACS only discovers integrations when they live in top-level folders with a
repository.yamlpresent — this repo had both nested one level deeper, which silently broke discovery.Home Assistant/addon/pi_somfy/→somfy-ha-addon/(repo root).Home Assistant/custom_components/pi_somfy/→custom_components/pi_somfy/(repo root) — required by HACS's integration structure check.repository.yamlat the repo root — required by Supervisor to recognize this as a valid app/add-on repository at all.my.home-assistant.ioHACS badge toREADME.md, and updated install instructions/paths to match the new layout.Verified locally: adding this repo (pinned to this branch) in Settings → Add-ons → Add-on Store → Repositories now succeeds and the add-on shows up.
No functional/runtime changes — file moves and doc/metadata only.