fix: mark inconclusive rounds as rewards_done to prevent queue leak#79
Merged
fix: mark inconclusive rounds as rewards_done to prevent queue leak#79
Conversation
Rounds with outcome=0 (Inconclusive) were collected into the reward jobs queue but silently skipped during processing without ever setting rewards_done=true. This caused them to accumulate indefinitely, wasting CPU and memory every tick.
jcabrero
force-pushed
the
fix/inconclusive-round-leak
branch
from
b6c7b8d to
4e45467
Compare
Extract collect_round_jobs into a standalone function and add 5 unit tests covering inconclusive rounds, conclusive rounds, jailing policy, and already-processed rounds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
outcome=0(Inconclusive) were collected into the reward jobs queue every tick but silently skipped during processing, without ever settingrewards_done = truerewards_done = trueat collection time so they are excluded from future ticks