Open
Conversation
samvaity
reviewed
Jun 17, 2024
|
|
||
| System.out.println("Printing resourceList"); | ||
| System.out.println(resourceList); | ||
| if (resourceList != null) { |
Collaborator
There was a problem hiding this comment.
Is this working now?
Also, did you figure out unit tests?
lmolkova
reviewed
Jul 25, 2024
| * This method checks if the variable is closed elsewhere in the source code. | ||
| * It checks if the variable is closed in the finally block of a try statement or if it is closed elsewhere in the source code. | ||
| */ | ||
| private static boolean isResourceClosed(PsiVariable variable, PsiElement element) { |
There was a problem hiding this comment.
would it detect issues if I do this:
void doStuff() {
Client client = createClient();
// it's ok if we can't detect all possible cases when variable is reassigned multiple times
}
Client createClient() {
Client c = new Client();
...
return c;
}or
void doStuff() {
Client client = createClient();
// important that we don't report issue here
client.close();
}
Client createClient() {
Client c = new Client();
...
return c;
}?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This class contains the inspection tool for checking if Closeable clients are properly closed.
It checks if the Closeable client is declared in a try-with-resources block or if it is closed in the code block.
If the Closeable client is not closed, it registers a problem with the ProblemsHolder.
currently can identify closeable clients in the PSI tree
Has this been tested?
Any relevant logs, screenshots, error output, etc.?