Skip to content

#543 transition DataTypeEnum to topic.utils.ts #545

Merged
lucy-shah merged 2 commits intodevelopfrom
543-Topic-enum-to-topic-util-transition
Mar 24, 2026
Merged

#543 transition DataTypeEnum to topic.utils.ts #545
lucy-shah merged 2 commits intodevelopfrom
543-Topic-enum-to-topic-util-transition

Conversation

@lucy-shah
Copy link
Copy Markdown
Contributor

Changes

Transitioned all static topics from data-type.enum.ts to topic.utils.ts as arrow functions and added them to the topics export object. Replaced all 103 usages of DataTypeEnum across 31 consumer files with the equivalent topics.x() calls. Deleted data-type.enum.ts.

Notes

Also added fake/mock data topics (motorUsage, coolingUsage, steeringAngle, torque, brakePressure, acceleration, xyzAcceleration) to topic.utils.ts as these were previously only in the enum.

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • [x ] All commits are tagged with the ticket number
  • [ x] No linting errors / newline at end of file warnings
  • [ x] All code follows repository-configured prettier formatting
  • [ x] No merge conflicts
  • [x ] All checks passing
  • [ x] Remove any non-applicable sections of this template
  • [ x] Assign the PR to yourself
  • [ x] No package-lock.json changes (unless dependencies have changed)
  • [x ] Request reviewers & ping on Slack
  • [ x] PR is linked to the ticket (fill in the closes line below)

Closes # 543

@lucy-shah lucy-shah requested a review from bracyw March 23, 2026 22:12
@lucy-shah lucy-shah self-assigned this Mar 23, 2026
@lucy-shah lucy-shah merged commit de47282 into develop Mar 24, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants