[19.0][FIX] edi_core_oca: use savepoint to prevent state corruption on errors#316
Merged
OCA-git-bot merged 1 commit intoJul 3, 2026
Merged
Conversation
Some errors such as ValueError, FileNotFoundError, exceptions.UserError, exceptions.ValidationError, are caught, never re-raised, and the transaction is finally committed. Which means a UserError/ValidationError gets committed, leading to corruption of the processed data.
Contributor
guewen
changed the title
etobella
approved these changes
Jul 3, 2026
simahawk
approved these changes
Jul 3, 2026
Contributor
|
/ocabot merge patch |
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
Congratulations, your PR was merged at 4bce3cf. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward #284