[18.0][FIX] web_notify: remove unsupported messageIsHtml prop#3587
Conversation
- Odoo 18 notification component uses strict OWL prop validation and does not accept messageIsHtml, the markup() wrapper already handles HTML rendering. Fixes: OCA#3392
|
This PR has the |
Tisho99
left a comment
There was a problem hiding this comment.
LGTM. Functional and technical review.
I was experiencing some JS errors when using this module to generate notifications, and this PR fixes it.
I have confirmed that the the markup() wrapper already handles HTML rendering, and that the messageIsHtml has been removed from notification.js (See old version to compare)
As additional info, you can see this FIX in other odoo modules: odoo/odoo#84701
|
Hello @Pepo48 Could you please rename this PR to: [18.0][FIX] web_notify: remove unsupported messageIsHtml prop If we add "[18.0][FIX]", the name is more adapted to OCA conventions. It can help this PR to be merged by a PSC Thanks! |
|
@Tisho99 done. Thanks for the heads-up. |
|
Hello @OCA/web-maintainers Could someone please take a look at this FIX? It is very small, it has the ready to merge label, as it has 3 reviews of different companies. Thanks in advance! |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 5aaff61. Thanks a lot for contributing to OCA. ❤️ |
Fixes: #3392