Skip to content

[18.0][FIX] web_notify: remove unsupported messageIsHtml prop#3587

Merged
OCA-git-bot merged 1 commit into
OCA:18.0from
Pepo48:issue-3392
Jul 14, 2026
Merged

[18.0][FIX] web_notify: remove unsupported messageIsHtml prop#3587
OCA-git-bot merged 1 commit into
OCA:18.0from
Pepo48:issue-3392

Conversation

@Pepo48

@Pepo48 Pepo48 commented Jun 14, 2026

Copy link
Copy Markdown
Contributor
  • Odoo 18 notification component uses strict OWL prop validation and does not accept messageIsHtml, the markup() wrapper already handles HTML rendering.

Fixes: #3392

- Odoo 18 notification component uses strict OWL prop validation and does not accept messageIsHtml, the markup() wrapper already handles HTML rendering.

Fixes: OCA#3392
@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@Tisho99 Tisho99 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Functional and technical review.

I was experiencing some JS errors when using this module to generate notifications, and this PR fixes it.

I have confirmed that the the markup() wrapper already handles HTML rendering, and that the messageIsHtml has been removed from notification.js (See old version to compare)

As additional info, you can see this FIX in other odoo modules: odoo/odoo#84701

@Tisho99

Tisho99 commented Jul 14, 2026

Copy link
Copy Markdown

Hello @Pepo48

Could you please rename this PR to:

[18.0][FIX] web_notify: remove unsupported messageIsHtml prop

If we add "[18.0][FIX]", the name is more adapted to OCA conventions.

It can help this PR to be merged by a PSC

Thanks!

@Pepo48 Pepo48 changed the title web_notify: remove unsupported messageIsHtml prop [18.0][FIX] web_notify: remove unsupported messageIsHtml prop Jul 14, 2026
@Pepo48

Pepo48 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

@Tisho99 done. Thanks for the heads-up.

@Tisho99

Tisho99 commented Jul 14, 2026

Copy link
Copy Markdown

Hello @OCA/web-maintainers

Could someone please take a look at this FIX?

It is very small, it has the ready to merge label, as it has 3 reviews of different companies.

Thanks in advance!

@StefanRijnhart StefanRijnhart left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@hhgabelgaard FYI as you introduced this in #3291

/ocabot merge patch

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-3587-by-StefanRijnhart-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 30be3b2 into OCA:18.0 Jul 14, 2026
9 checks passed
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 5aaff61. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

web_notify: unknown key 'messageIsHtml'

6 participants