Skip to content

Refactor ACE explosives to use Explode event handler #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fank merged 1 commit into from
Feb 3, 2026
Merged

Refactor ACE explosives to use Explode event handler #42

fank merged 1 commit into from
Feb 3, 2026
+27 −37

Conversation

@fank
Copy link
Member

@fank fank commented Feb 3, 2026

Summary

  • Replace CBA_fnc_waitUntilAndExecute polling with Explode event handler for detonation detection
  • Add proper private declarations to local variables
  • Remove unused _markColor and _markerType variables (inlined)

Test plan

  • Place ACE explosive in mission with OCAP recording enabled
  • Verify minefield marker appears on timeline when explosive is placed
  • Detonate explosive and verify detonation marker (X) appears
  • Verify markers are cleaned up correctly after detonation

@fank
Refactor ACE explosives to use Explode event handler
39c0dd4 
Replace polling with waitUntilAndExecute with Explode event handler
for more efficient and event-driven detonation detection.
@fank fank merged commit 15c707b into main Feb 3, 2026
1 check passed
@fank fank deleted the refactor/ace-explosives-event-handler branch February 3, 2026 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fank