Skip to content

IEEEST Stabilizer Improvements/Corrections#460

Open
lukelowry wants to merge 2 commits into
developfrom
lukel/ieeest-dev
Open

IEEEST Stabilizer Improvements/Corrections#460
lukelowry wants to merge 2 commits into
developfrom
lukel/ieeest-dev

Conversation

@lukelowry

@lukelowry lukelowry commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

Description

Fixes and cleans up the IEEEST stabilizer implementation and documentation.

This updates the older initial implementation style so that reduced-order notch filters and zero denominator time constants are handled consistently

Proposed changes

  • Replace the branchy/safe-inverse notch logic with a fixed DAE form using differential tags.
  • Initialize IEEEST from the attached input signal instead of forcing all states to zero.
  • Document the implemented equations, initialization, derived parameters, and unsupported compatibility parameters.
  • Tests for initialization, residuals, invalid wiring, invalid notch parameters, zero time constants, and Jacobian consistency.

Checklist

  • All tests pass for the focused PhasorDynamics coverage.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.

Changelog changes N/A

Further comments

This is cleanup/correction work for the existing IEEEST model, not a new model

@lukelowry lukelowry marked this pull request as ready for review June 22, 2026 18:43
@lukelowry

Copy link
Copy Markdown
Collaborator Author

@pelesh this fix is also ready to be merged I forgot to make a PR for this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant