Skip to content

temporal dbif for current mapset only#2448

Open
metzm wants to merge 11 commits into
OSGeo:mainfrom
metzm:temporal_only_current_mapset
Open

temporal dbif for current mapset only#2448
metzm wants to merge 11 commits into
OSGeo:mainfrom
metzm:temporal_only_current_mapset

Conversation

@metzm

@metzm metzm commented Jun 17, 2022

Copy link
Copy Markdown
Contributor

Sometimes only the current mapset must be used by TGIS, particularly if the TGIS db is going to be modified. TGIS dbs in other mapsets can/should not be modified, only queried.

This PR adds functionality to initialize a SQLDatabaseInterfaceConnection with only the current mapset.

@metzm metzm added enhancement New feature or request temporal Related to temporal data processing Python Related code is in Python labels Jun 17, 2022
@metzm metzm added this to the 8.4.0 milestone Jun 17, 2022
@metzm
metzm requested a review from wenzeslaus June 17, 2022 17:05

@wenzeslaus wenzeslaus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable. I have some documentation and stylistic notes.

Comment thread python/grass/temporal/core.py Outdated
Comment thread python/grass/temporal/core.py
@metzm
metzm force-pushed the temporal_only_current_mapset branch from f1e11da to 53baae9 Compare June 20, 2022 08:34
wenzeslaus
wenzeslaus previously approved these changes Jun 20, 2022

@wenzeslaus wenzeslaus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as the code goes, this is good to go.

@metzm

metzm commented Jun 20, 2022

Copy link
Copy Markdown
Contributor Author

A related test for TGIS mapset access is failing. This needs to be fixed first before merging.

@metzm

metzm commented Jun 23, 2022

Copy link
Copy Markdown
Contributor Author

A related test for TGIS mapset access is failing. This needs to be fixed first before merging.

This will require a bit more effort because GRASS TGIS still expects at various different places that a raster/raster3d/vector map can only be registered in a TGIS db in the same mapset where this map is located. This prevents registering maps from a different mapset in a space-time dataset in the current mapset and subsequent modifications of this space-time dataset in the current mapset.

A solution would be to not only store information about the mapset of a map, but also information about the mapset of the space-time dataset that is currently used and where this map is registered in the internal structures of the temporal framework.

The historical background is that a map could only be registered in a space-time dataset if both are in the current mapset.

@wenzeslaus

Copy link
Copy Markdown
Member

At this point, this seems like something for 8.4.0.

@neteler

neteler commented Apr 16, 2023

Copy link
Copy Markdown
Member

@metzm shall I bump this PR to 8.4.0?

@wenzeslaus wenzeslaus modified the milestones: 8.3.0, 8.4.0 May 12, 2023
@metzm
metzm force-pushed the temporal_only_current_mapset branch from 22e8ba7 to e0692ae Compare September 3, 2023 09:44
@metzm
metzm force-pushed the temporal_only_current_mapset branch from b89d46f to 36eb604 Compare September 11, 2023 09:13
@landam

landam commented Nov 20, 2023

Copy link
Copy Markdown
Member

@metzm Please consider merging this PR.

@wenzeslaus wenzeslaus modified the milestones: 8.4.0, 8.5.0 Apr 26, 2024
@echoix echoix added the conflicts/needs rebase Rebase to or merge with the latest base branch is needed label Nov 7, 2024
@echoix

echoix commented Nov 10, 2024

Copy link
Copy Markdown
Member

I tried to solve conflicts, but I couldn't make sense of the changes in regards to changing self.mapset to self.data_mapset, that didn't seem used correctly. So I aborted it.

@wenzeslaus wenzeslaus modified the milestones: 8.5.0, 8.6.0 Dec 15, 2025
@ninsbl

ninsbl commented Jul 16, 2026

Copy link
Copy Markdown
Member

There have been a couple of recent changes that overlap with this PR:
#7707
#7672
#7671
And there is pending: #7670 which looks at this from a different perspective...
Will look into this as part of the Community meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conflicts/needs rebase Rebase to or merge with the latest base branch is needed enhancement New feature or request libraries module Python Related code is in Python temporal Related to temporal data processing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants