v.proj: Seed region from default window to ignore region override#7578
Open
petrasovaa wants to merge 2 commits into
Open
v.proj: Seed region from default window to ignore region override#7578petrasovaa wants to merge 2 commits into
petrasovaa wants to merge 2 commits into
Conversation
github-actions
Bot
added
vector
wenzeslaus
requested changes
Jun 18, 2026
wenzeslaus
requested changes
Jul 13, 2026
wenzeslaus
left a comment
wenzeslaus
left a comment
Member
There was a problem hiding this comment.
Use Tools also for g.region and g.findfile.
Comment on lines
+41
to
+50
| gs.run_command( | ||
| "g.region", | ||
| n=300000, | ||
| s=200000, | ||
| e=700000, | ||
| w=600000, | ||
| res=10, | ||
| save="local_region", | ||
| env=session.env, | ||
| ) |
Member
There was a problem hiding this comment.
The g.region call as well and find_file can be replaced by tools (no explicit env=session.env and more consistent overall; would make a good example).
Since the introduction of find_file wrapper, g.findfile gained JSON output and the return value was fixed to a more expected behavior for a GRASS tool, while the test unix utility behavior is available with a flag (not by default).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This came up when i was testing r.in.ssurgo addon in parallel within RegionManager which uses WIND_OVERRIDE. v.proj was throwing:
Added test.
More info:
Details
When v.proj switches into the source project to read the input vector, it seeded its working region with G_get_window(), which honors WIND_OVERRIDE and GRASS_REGION. Those name a region in the caller's mapset, not in the source project, so the read failed with "Unable to open element file " whenever v.proj ran under a named temporary region (e.g. inside RegionManager, use_temp_region(), or parallel pipelines).Read the source project's default window instead. The seed value is
overwritten field by field from the input vector's extent immediately
afterward, so seeding from the default window is sufficient and does not
consult the override. G_unset_window() is dropped since it only existed
to defeat G_get_window()'s cache.
Add a regression test that runs v.proj with WIND_OVERRIDE naming a region
present only in the target mapset