fix: add security-events permission to self-scan and docs#352
Merged
Conversation
The self-scan-action job was missing the security-events: write permission required by github/codeql-action/upload-sarif. Also updated the SARIF and workflow-integration docs to show the full job with the required permission block, so users know it must be declared in the calling workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
self-scan-actionjob was failing becausegithub/codeql-action/upload-sarifrequiressecurity-events: writeon the calling job — it cannot be satisfied inside the composite action itself.Updated
website/docs/sarif.mdandwebsite/docs/workflow-integration.mdto show the full job block with the requiredpermissionsdeclaration, so users know where to put it.Closes #353