cmd: improve split keys behavior#4577
Open
pinebit wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4577 +/- ##
==========================================
- Coverage 57.21% 57.21% -0.01%
==========================================
Files 245 245
Lines 33449 33455 +6
==========================================
+ Hits 19139 19142 +3
+ Misses 11886 11884 -2
- Partials 2424 2429 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Restore deposit data creation when splitting existing keys and instead document the behavior in the --split-existing-keys flag help: deposit data files are re-created using the provided withdrawal addresses and must not be submitted for validators that are already active. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve
charon create cluster --split-existing-keysbehavior:keystore-N.jsonis paired with the Nth per-validator addresses. Previously only multiple--withdrawal-addressestriggered ordered loading; multiple fee recipients or a definition file with distinct addresses paired keys with addresses nondeterministically.--split-existing-keyshelp text: deposit data files are re-created in split mode using the provided withdrawal addresses, and must not be submitted for validators that are already active. The flag previously claimed deposit data is not re-created.Documentation is updated accordingly in ObolNetwork/obol-gitbook#164.
category: bug
ticket: none
🤖 Generated with Claude Code