chore: remove redundant Google Services config - #2699
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
📊 Diff Coverage Report✓ Coverage check passed (no source files changed) |
nan-li
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Remove the unnecessary Google Services Gradle plugin and Firebase configuration from the Android demo.
Details
Motivation
OneSignal initializes its own named Firebase app, so the demo does not need the Google Services plugin or
google-services.jsonto build the GMS variant or register for push.Scope
Removes the Google Services plugin setup and demo Firebase configuration. The GMS and Huawei product flavors remain unchanged.
Testing
Manual testing
Ran
./gradlew :app:assembleGmsDebug. Manifest and resource processing completed without Google Services configuration. Compilation later failed on pre-existing JWT API references that are unavailable in the demo default SDK version (5.6.1). No device testing was needed for this build-configuration cleanup.Affected code checklist
Checklist
Overview
Testing
Final pass
Made with Cursor