Skip to content

chore: remove redundant Google Services config - #2699

Merged
fadi-george merged 1 commit into
mainfrom
cursor/remove-google-services-plugin
Jul 28, 2026
Merged

chore: remove redundant Google Services config#2699
fadi-george merged 1 commit into
mainfrom
cursor/remove-google-services-plugin

Conversation

@fadi-george

Copy link
Copy Markdown
Contributor

Description

One Line Summary

Remove the unnecessary Google Services Gradle plugin and Firebase configuration from the Android demo.

Details

Motivation

OneSignal initializes its own named Firebase app, so the demo does not need the Google Services plugin or google-services.json to build the GMS variant or register for push.

Scope

Removes the Google Services plugin setup and demo Firebase configuration. The GMS and Huawei product flavors remain unchanged.

Testing

Manual testing

Ran ./gradlew :app:assembleGmsDebug. Manifest and resource processing completed without Google Services configuration. Compilation later failed on pre-existing JWT API references that are unavailable in the demo default SDK version (5.6.1). No device testing was needed for this build-configuration cleanup.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

Made with Cursor

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions

Copy link
Copy Markdown
Contributor

📊 Diff Coverage Report

✓ Coverage check passed (no source files changed)

📥 View workflow run

@fadi-george
fadi-george merged commit 8519aff into main Jul 28, 2026
5 checks passed
@fadi-george
fadi-george deleted the cursor/remove-google-services-plugin branch July 28, 2026 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants