chore: [SDK-4975] consume KMP in iOS SDK - #1698
Merged
Merged
Conversation
abdulraqeeb33
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Pin the shared KMP repository and link its static XCFramework internally into
OneSignalCore.Details
Motivation
The iOS SDK needs the same shared logger implementation as Android while preserving the existing public SPM and CocoaPods dependency surface. KMP releases must also be able to advance both host SDKs in lockstep.
Scope
OneSignal-KMP-SDKas a pinned git submoduleOneSignalCorefor iOS device and simulator buildsNo Swift adapters or logger calls are included; those remain follow-up work.
Dependencies
Testing
Unit testing
The shared KMP JVM, iOS simulator, and XCFramework verification tasks pass. The local reduced iOS test plan produced 138 passes and 9 existing state/timing-sensitive failures under Xcode 26.5; CI uses Xcode 16.4, which is unavailable locally.
Manual testing
OneSignalCorefor generic iOS device and simulator destinationsOneSignalCorefor Mac Catalyst to confirm the conditional KMP link does not affect CatalystOSKMPLoggerFactorysymbols are embedded in the simulatorOneSignalCorebinaryAffected code checklist
Checklist
Overview
Testing
Final pass
Made with Cursor