Add keyboard wrapper library (Refactor for Onion#1318)#10
Open
Infernoss2 wants to merge 5 commits intoOnionUI:mainfrom
Open
Add keyboard wrapper library (Refactor for Onion#1318)#10Infernoss2 wants to merge 5 commits intoOnionUI:mainfrom
Infernoss2 wants to merge 5 commits intoOnionUI:mainfrom
Conversation
If we quit SDL it also kills the parents SDL environment
Causes segfaults in sdl_ttf when apps aren't launch from .tmp_update/bin
Member
|
Checked the changes, looks good. What's your testing checklist look like for this change ? Happy to review and merge now if it's tested fully 👍 |
Author
|
Unfortunately I dont have the physical Miyoo Mini device, so I cannot test the graphical UI execution. Here is what I have could check:
If there is anything else you want me to check/do pls tell me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the keyboard wrapper library needed for global GUI support (resolves OnionUI/Onion#1318), building on @XK9274's initial work.
Changes:
Extracted launch_keyboard from main.cpp into a dedicated keyboard_lib.cpp.
Added extern "C" linkage in keyboard.h for compatibility with Onion's C codebase.
Implemented dup_cstr to safely allocate strings (ownership transferred to the C caller).