Conversation
Contributor
Author
|
😓 |
Member
|
пока занят |
ziggi
requested changes
Feb 25, 2026
Member
ziggi
left a comment
ziggi
left a comment
There was a problem hiding this comment.
Заменять вызов Lang_GetPlayerLang на обращение к массиву это уже слишком, так и для пропуска инициализации можно дойти. Оптимизировать так, чтобы скорость работы соответствовала SendClientMessage можно только через отказ от SVar/GVar, в рамках этой библиотеки это не вариант.
Ну и менять названия аргументов тоже не надо, сейчас используются стандартные для SA-MP названия.
Comment on lines
1466
to
1472
| forward _Lang_SysreqFix(); | ||
| public _Lang_SysreqFix() | ||
| { | ||
| new temp[2]; | ||
| format(temp, sizeof(temp), ""); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Это исправляет краш на дефолтном компиляторе, убирать не надо
NikitaFoxze
force-pushed
the
micro-optimization
branch
from
943d1dc to
dc7b530
Compare
…lang into micro-optimization
Contributor
Author
|
Исправил, только не понял момент, я сделал слияние с текущей версии и почему-то PR закрылся, странно |
ziggi
requested changes
Feb 25, 2026
zlang.inc
Outdated
Comment on lines
954
to
955
| } | ||
| else { |
Member
There was a problem hiding this comment.
По форматированию else и } должны быть на одной строке, но здесь else вообще не нужен
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Между вызовом нативного
SendClientMessageиLang_SendTextразница по скорости - пропасть, хотелось бы по максимуму, насколько это возможно, оптимизировать некоторые моменты.numargsдля форматирования,Lang_GetPlayerLangизменил вызов функции на массив,LANG_PROCESS_VARS_NAME.