Fix x-spring-provide-args handling. Pass arguments to delegates. Use JavaParser.#24071
Open
wilx wants to merge 1 commit into
Open
Fix x-spring-provide-args handling. Pass arguments to delegates. Use JavaParser.#24071wilx wants to merge 1 commit into
wilx wants to merge 1 commit into
Conversation
80ccb69 to
c3766cd
Compare
Contributor
There was a problem hiding this comment.
1 issue found and verified against the latest diff
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Member
|
please resolve the merge conflicts when you've time |
Author
Resolved. |
5 tasks
c75169d to
80f02f7
Compare
Author
|
I have identified some issues with the patch related to comma handling. I am working on a fix. |
80f02f7 to
b85a6a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #24063. This is an alternative to #24064. This utilizes JavaParser instead of regular expressions to extract the information it needs.
Summary by cubic
Fixes handling of
x-spring-provide-argsby using JavaParser and wiring provided args through API interfaces, controllers, and delegates across all request mapping modes, including reactive and pageable combinations. Ensures correct imports, signatures, and call sites with proper comma/parameter ordering and forwarding methods inapi_interfacemode.Bug Fixes
x-spring-provide-argswith JavaParser (handles annotations and nested generics).api_interfacemode, controller-to-delegate flows, and interface-only setups.Pageable, and provided args across reactive and non-reactive modes; add tests for interface-only,api_interface, pageable, and controller-to-delegate flows.Dependencies
com.github.javaparser:javaparser-coreto compile scope.Written for commit b85a6a1. Summary will update on new commits.