Add RP2040 Support for JackW01 and BTT SKR Pico boards - #298
Open
EricSchubert wants to merge 6 commits into
Open
Add RP2040 Support for JackW01 and BTT SKR Pico boards#298EricSchubert wants to merge 6 commits into
EricSchubert wants to merge 6 commits into
Conversation
Fixes requested by julianneswinoga on PR OpenAstroTech#280 (see prior commit for detailed breakdown): restore accidentally-dropped defines/comments, remove references to unimplemented boards, fix invalid platformio.ini library specs, and revert the unrelated Mount.cpp/Mount.hpp refactor back to only the toff(1)->toff(4) StealthChop change actually needed for RP2040 support. Verified: rp2040_jackw01 and rp2040_skr_pico build and flash cleanly; SKR Pico hardware responds correctly to Meade commands after flashing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #280, which had to be closed after a force-push broke its
shared history with
develop(see #280 for the full review discussionwith @julianneswinoga — all her feedback is addressed in this branch).
Adds RP2040 support for two boards:
All review comments from #280 are addressed:
the OAE validation branch that were accidentally dropped
#version for git-hosted deps)
bundled into the port, keeping only the toff(1)->toff(4) change
actually needed for TMC2209 StealthChop on RP2040
Verified: rp2040_jackw01 and rp2040_skr_pico build and flash cleanly;
SKR Pico hardware responds correctly to Meade protocol commands.