refactor(drivers/wps): remove resolveCache#2411
Merged
xrgzs merged 3 commits intoOpenListTeam:mainfrom Apr 27, 2026
Merged
Conversation
Signed-off-by: MadDogOwner <xiaoran@xrgzs.top>
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the WPS driver to remove the old path-resolution cache and instead rely on driver-specific object metadata (IDs/kinds), while also improving HTTP client isolation and request headers (UA).
Changes:
- Removed resolveCache/resolvePath-based workflow and moved to object-type assertions with richer
Objmetadata. - Added per-driver
resty.Clientinitialization on startup and login-state detection viaislogin. - Extracted upload logic into a dedicated
put.goand added configurable/custom User-Agent support.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| drivers/wps/util.go | Reworked endpoints, UA handling, request creation, and group fetching to rely on login state + per-driver client. |
| drivers/wps/types.go | Introduced loginState, moved API response types, and redesigned Obj to embed model.Obj plus driver metadata. |
| drivers/wps/put.go | New file containing upload implementation (hashing, create/commit, multipart/stream handling). |
| drivers/wps/meta.go | Updated driver addition fields (default mode, custom UA, tag metadata changes). |
| drivers/wps/driver.go | Rebuilt core driver methods (List/Link/CRUD/GetDetails) to use the new object model and initialized resty client + login state in Init. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <copilot@github.com> Signed-off-by: MadDogOwner <xiaoran@xrgzs.top>
Signed-off-by: MadDogOwner <xiaoran@xrgzs.top>
7 tasks
jyxjjj
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description / 描述
Motivation and Context / 背景
How Has This Been Tested? / 测试
实测WPS365商业版,WPS个人版可正常上传、复制、新建文件夹,说明类型断言实现没问题。
Checklist / 检查清单
我已阅读 CONTRIBUTING 文档。
go fmtor prettier.我已使用
go fmt或 prettier 格式化提交的代码。我已为此 PR 添加了适当的标签(如无权限或需要的标签不存在,请在描述中说明,管理员将后续处理)。
我已在适当情况下使用"Request review"功能请求相关代码作者进行审查。
我已相应更新了相关仓库(若适用)。