-
Notifications
You must be signed in to change notification settings - Fork 0
feat(spp_dci_demo): add DCI birth verification demo module and Conditional Child Grant #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jeremi
wants to merge
10
commits into
feat/dci-client-improvements
Choose a base branch
from
feat/dci-demo-module
base: feat/dci-client-improvements
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
c8937ac
feat(dci-demo): add DCI birth verification demo module
jeremi e09ac76
fix(dci-demo): handle reg_records in OpenCRVS SPDCI response format
jeremi 65e5c98
fix(dci-demo): add auto-approve to wizard flow
jeremi 64b4d6e
fix(dci-demo): hide data source selector when only one CRVS registry …
jeremi 5fb4be8
refactor(spp_dci_demo): remove wizard, consolidate auto-approval in _…
jeremi 43850e3
feat(spp_dci_demo,spp_mis_demo_v2): add Conditional Child Grant and d…
jeremi 7ee52e1
fix(spp_dci_demo): invalidate membership cache before enrollment and …
jeremi b7ecdf8
fix(spp_dci_demo): remove deprecated manifest keys, fix XML IDs and s…
jeremi 76e158e
fix(spp_dci_demo): fix XML ID naming and remaining semgrep finding
jeremi a9a731d
chore(spp_dci_demo): add auto-generated pyproject.toml from whool hook
jeremi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RegistryType enum value change lacks data migration
Medium Severity
The
RegistryTypeenum values changed from short strings (e.g.,"CRVS","SOCIAL_REGISTRY") to namespaced strings (e.g.,"ns:org:RegistryType:Civil","ns:org:RegistryType:Social"), but there is no data migration for existingspp.dci.data.sourcerecords. Existing records still store the old values in theregistry_typeSelection field, which no longer match any valid option. This causes_get_registry_type()to silently fall back toSOCIAL_REGISTRYfor CRVS sources, andcrvs_service.pyto reject them outright with aValidationError.Additional Locations (1)
spp_dci_client/services/client.py#L522-L523