Skip to content

Feat/add more config vars#113

Open
dotconfig404 wants to merge 2 commits intoOpenVoxProject:mainfrom
dotconfig404:feat/add_more_config_vars
Open

Feat/add more config vars#113
dotconfig404 wants to merge 2 commits intoOpenVoxProject:mainfrom
dotconfig404:feat/add_more_config_vars

Conversation

@dotconfig404
Copy link
Contributor

Hi

hope to get a few config env vars added.

  1. setting a ENC script via via EXTERNAL_NODES -> this also sets node_terminus to exec as that is required for external_nodes to work. other possible values for node_terminal are plain and classifier. The latter being puppet enterprise specific so not relevant here, and plain disabling ENC/ using buillt-in node classification.

  2. setting allow_duplicate_certs via ALLOW_DUPLICATE_CERTS. This is done in the appropiate script for other CA settings, 90-ca.sh when CA is enabled.

Cheers

Copy link

cvquesty commented Mar 9, 2026

I humbly ask we do not remove the external classifier if we can help it. I have both an ENC and a packaged frontend project, each of which rests on that functionality. It would kill two entire projects I maintain.

@dotconfig404
Copy link
Contributor Author

Hi, are you talking about setting node_terminus to classifier? This is not affected by it, it just sets node_terminus to exec if external_nodes is to be set which AFAIK can only work if exec is set. Default behaviour is uncahnged with this PR and nothing gets removed.

I am curious though, your ENC uses classifier or exec for node_terminus?

@cvquesty
Copy link

cvquesty commented Mar 9, 2026

I'm just being selfish. :D I just wanted to make sure my ENC and the OpenVox GUI project weren't affected.

Thank you for easing my fears!

I use

node_terminus = exec
external_nodes = /path/to/classifier

@dotconfig404
Copy link
Contributor Author

BTW, I checked out your project and damn it looks really nice! Been working on a ENC myself the past couple of months, but it has maybe only half the functionality of openvox-gui. This is really more than just a ENC/ report dashboard. Very cool.

@cvquesty
Copy link

cvquesty commented Mar 9, 2026 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants