Conversation
bastelfreak
approved these changes
Mar 8, 2026
Contributor
bastelfreak
left a comment
bastelfreak
left a comment
There was a problem hiding this comment.
In theory this is a breaking change, but I think puppet_connect is dead anyways, so we could remove it in a minor release?
Contributor
Author
|
I'm not sure also.. I don't think we have any user of this feature tbh.. |
Member
|
If I’m remembering correctly, this was a Puppet product that never really came to pass. Should be good dropping it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.