drop gettext from jruby gems

[jcharaoui]

this gem was likely added to support the (brief) module localization effort, in addition to fast_gettext, but it's probably unused by now

see also puppetlabs/r10k#1407

[jcharaoui]

FWIW I added this patch in the Debian puppetserver package: https://sources.debian.org/src/puppetserver/8.7.0-6/debian/patches/drop-gettext.patch

[ekohl]

There's a merge conflict. Mind rebasing?

I also did some digging. There used to be a dependency on gettext-setup which pulled in gettext but since OpenVoxProject/openvox@53aa50a this is no longer a thing.

[bastelfreak]

I build this locally:

DEB_PLATFORMS='ubuntu-22.04' RPM_PLATFORMS='' bundle exec rake vox:build

And afterwards I still see the gem:

root@puppetserver:~# /opt/puppetlabs/server/bin/puppetserver gem info gettext
2026-01-02 12:59:19,012 INFO  [p.s.j.jruby-puppet-core] Disabling i18n for puppet because using multithreaded jruby

*** LOCAL GEMS ***

gettext (3.5.1)
    Authors: Kouhei Sutou, Masao Mutoh
    Homepage: https://ruby-gettext.github.io/
    Licenses: Ruby, LGPL-3.0+
    Installed at: /opt/puppetlabs/puppet/lib/ruby/vendor_gems

    Gettext is a pure Ruby libary and tools to localize messages.
root@puppetserver:~#

[bastelfreak]

Edit:

this in fact works. Output from a build from main:

root@puppetserver:~# /opt/puppetlabs/server/bin/puppetserver gem info gettext
2026-01-02 12:50:00,375 INFO  [p.s.j.jruby-puppet-core] Disabling i18n for puppet because using multithreaded jruby

*** LOCAL GEMS ***

gettext (3.5.1)
    Authors: Kouhei Sutou, Masao Mutoh
    Homepage: https://ruby-gettext.github.io/
    Licenses: Ruby, LGPL-3.0+
    Installed at: /opt/puppetlabs/server/data/puppetserver/vendored-jruby-gems

    Gettext is a pure Ruby libary and tools to localize messages.
root@puppetserver:~#

gettext is available in both cases. But on main it's coming from /opt/puppetlabs/server/data/puppetserver/vendored-jruby-gems. openvox-server also loads the gems from the agent. With this PR, it's loaded from /opt/puppetlabs/puppet/lib/ruby/vendor_gems. So the PR is fine.

---

Do we consider the list of gems a stable API? Is it a breaking change if we remove gems? Is that something we should discuss on the mailinglist or just write into the release notes?

[ekohl]

gettext is available in both cases. But on main it's coming from /opt/puppetlabs/server/data/puppetserver/vendored-jruby-gems. openvox-server also loads the gems from the agent. With this PR, it's loaded from /opt/puppetlabs/puppet/lib/ruby/vendor_gems. So the PR is fine.

I'd expect it not to be present anymore. Which package actually owns that?

Do we consider the list of gems a stable API? Is it a breaking change if we remove gems? Is that something we should discuss on the mailinglist or just write into the release notes?

That is a good question.