Speed up make check ~5x#459
Merged
Victor Schappert (vcschapp) merged 1 commit intodevfrom Mar 9, 2026
Merged
Conversation
Geometry constraint tests: replace full powerset (127 subsets of 7 geometry types) with singletons + pairs + full set (29 subsets). GeometryTypeConstraint is a set-membership check — combinatorial testing beyond pairs exercises no additional code paths. Makefile: run pytest, doctest, ruff, and mypy concurrently via make -j after a single upfront uv-sync. Added -only variants (no uv-sync dep) for the parallel invocation; standalone targets preserved with their original uv-sync dependencies.
Collaborator
Thanks for this - it's been on my agenda for a while and I've been too lazy to this point. |
Victor Schappert (vcschapp)
approved these changes
Mar 9, 2026
Collaborator
Victor Schappert (vcschapp)
left a comment
Victor Schappert (vcschapp)
left a comment
There was a problem hiding this comment.
She's the ship that did $ make check in under 12 parsecs!
Millenium Falcon
____ ____
/ --.| |.-- \
/,---|| ||---.\
// || || \\
// || || \\
// __ || || __ \\
//,' `. || || ,'||`.\\
//( \`--|)|| ||( \'| )\\
// `.-_,' ||________|| `.-_,' \\
// | || _| || \\
// | || | .. | || \\
// | || | :: | || \\
/ __ 888|| | _ | || __ \
/ ,'|_'. _ 888|| | | | || _ ,'-.`. \
/ ( ,-._ | |888|| | -| | || |_| ( |==) \
/ `O__,'|_|8@ || | [| | |@ |_| `._|,' \
/ __..|--| | )| | |--|_|__ \ ,==.
/ __,--'' | | | | | ``--.__ \ //[]\\
/ ,::::' |-=| | | |::::.. `-. \ //||||\\
/ ,-'::::: ..::| | /| | |:::::::: `-. \ ||,' `.||
/ ,' '' ::::::| | \| | | '':::: oo `. \ |--------|
/,' ,'\ :::'''|] | | | | .... o8888o `.\ |:::_[[[[]
/' ,' ) |> | | | [| :::::: 88888 .. \ | | ]
/ ,' | |] |=_| | [| '::::'oo 8 :::: \-' |---|
.' o ,' \_/ | :| \| |.[| o8888o ::;-' ,' |
,' o88,' `._/:\| | :| | |: | 88888888 ,-' \ _,-' |
| 8888 ``--'|::::| |_:| | |:_| 8888 ,-' \ ,-' .::_,-'
,' 8888 ''--"" || || [| || || ,-' _,-' \ _::'
| || |_,--._| || ,-' \ ,-' _,-'
| |__(______)__| ,-' _,-' .::_,-' |
|' 88o =====,,--..===== .-' ,-' \ _::' `|
| 888888o ,-'\ /`-. \ \-' . _,-' |
`---._____ 888888888 ,' / [HHHH[=====- \ |_::' _____.---'
__|_____`=======._____ / \ [HHHH[=====- `'__.======='_____|__
{I | _______________ || / /\/____\/\:. \ || _______________ | I}
[I | :___]__[_______ ||( / _.._ \:. )|| ______]___[___: | I]
{I_|____________o8o___|| \ /: /\ /\ \: / ||__________________|_I}
|_____,------' \/:' \ \/ / \/:.. 88`-------._____|
.---' :::::: `. [||||] ,' '::.. `---.
| '::..:: ,' `-. ,-' `. ':' |
|. .:::'' ,' __ ``--'' __ `. .::. ,|
| ''' ,' ,'||`. __ ,'||`. `. '::::. |
| ,' (||||||) ,'||`. (||||||) 88. '::::. |
`. ,' `.||,' (||||||) `.||,' 88888. ':' ,'
| ,' __ `.||,' __ 88 `. |
`. ,' ,'||`. __ ,'||`. `. ,'
`. ,' (||||||) ,'||`. (||||||) `. ,'
\ ,' `.||,' (||||||) `.||,' `. /
`. | `.||,' | ,'
`-| |-'
`. ,'. .`. ,'
`-:,'o88o ,/ \. `.;-'
`-888 // / ||ooo \ oo88 \\ __,-' Joe Reiss
`--..__ /' ||888 `\ oo8;--'
```-----''-----''''
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run test, doctest, lint, and mypy targets in parallel via
make -j, and replace the geometry type powerset (127 subsets) with representative subsets (singletons + pairs + full = 28 subsets).Changes
Makefile: Split each check target into a
-onlyvariant (nouv-syncdep) somake -jcan run them concurrently.checkdoes a singleuv-syncupfront, then fans out.test_geom.py: Replace powerset enumeration with singletons, pairs, and the full set. Covers individual type acceptance/rejection, pairwise composition, and unconstrained acceptance without combinatorial explosion.