Skip to content

Update event time limit messages#107

Open
zzufx wants to merge 1 commit intoPGMDev:devfrom
zzufx:event-time-limit
Open

Update event time limit messages#107
zzufx wants to merge 1 commit intoPGMDev:devfrom
zzufx:event-time-limit

Conversation

@zzufx
Copy link
Contributor

@zzufx zzufx commented Mar 3, 2026

Updates messages for event time host commands - one of them currently has the player name in a weird spot, as broadcastHostMessage requires it. It also shows two messages when updating the time limit, and uses "timelimit" instead of "time limit", which is how it appears in other places.

Before:
image
Note the name before "The".

After:
image

Copy link
Member

@applenick applenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this!

The original purpose of the event will now end in <duration> message was to preserve progress when updating the time limit mid-event. For example, if an event had been running for 25 minutes and the limit was extended to one hour, the elapsed time would still count. The second message was meant to give staff a clear view of the actual remaining time.

The <name> The event will now end… formatting was an oversight and should not have included the player name.

As for your changes, “from now” is not quite accurate here, since the command sets the event’s total length, not the remaining time directly.

A couple of options I’d suggest:

  • Keep your changes, remove “from now,” and add a hover message that reads Event will end in <time remaining>.

OR

  • Restore the second message by explicitly sending it via BroadcastUtils.sendAdminChatMessage(...) instead of broadcastHostAction, so it does not include the sender’s name.

Either approach works for me 👍

@zzufx zzufx force-pushed the event-time-limit branch from cf6bce0 to 3fb50a5 Compare March 3, 2026 18:04
@zzufx zzufx requested a review from applenick March 3, 2026 18:04
@applenick
Copy link
Member

@zzufx Changes look good 👍 Could you sign your commit when you get a chance? Then I’ll merge.

Signed-off-by: zzuf <11651753+zzufx@users.noreply.github.com>
@zzufx zzufx force-pushed the event-time-limit branch from 3fb50a5 to d76877c Compare March 4, 2026 02:12
@zzufx
Copy link
Contributor Author

zzufx commented Mar 4, 2026

@applenick Oops, sorry! Not sure what happened. Should be good to go now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants