Conversation
applenick
left a comment
There was a problem hiding this comment.
Thanks for looking into this!
The original purpose of the event will now end in <duration> message was to preserve progress when updating the time limit mid-event. For example, if an event had been running for 25 minutes and the limit was extended to one hour, the elapsed time would still count. The second message was meant to give staff a clear view of the actual remaining time.
The <name> The event will now end… formatting was an oversight and should not have included the player name.
As for your changes, “from now” is not quite accurate here, since the command sets the event’s total length, not the remaining time directly.
A couple of options I’d suggest:
- Keep your changes, remove “from now,” and add a hover message that reads
Event will end in <time remaining>.
OR
- Restore the second message by explicitly sending it via
BroadcastUtils.sendAdminChatMessage(...)instead ofbroadcastHostAction, so it does not include the sender’s name.
Either approach works for me 👍
|
@zzufx Changes look good 👍 Could you sign your commit when you get a chance? Then I’ll merge. |
Signed-off-by: zzuf <11651753+zzufx@users.noreply.github.com>
|
@applenick Oops, sorry! Not sure what happened. Should be good to go now! |
Updates messages for event time host commands - one of them currently has the player name in a weird spot, as broadcastHostMessage requires it. It also shows two messages when updating the time limit, and uses "timelimit" instead of "time limit", which is how it appears in other places.
Before:

Note the name before "The".
After:
