Merged
Conversation
By removing filenames from paths, the relative path to the reference will be created correctly.
When adding steps, the step's project files haven't been added to the `.App.csproj` and thus weren't loaded on startup.
There was a problem hiding this comment.
Pull Request Overview
This PR addresses fixing project references by updating the relative path calculation and refactoring functions for adding project references to separate concerns between test projects and the startup application.
- Updated relative path calculation in ProjectFileManipulation.cs to derive paths from directory names.
- Refactored AddStep.cs to separate startup application project reference addition from test projects processing.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Moryx.Cli.Commands/Components/ProjectFileManipulation.cs | Adjusted relative path calculation for project file references. |
| src/Moryx.Cli.Commands/AddStep.cs | Split project reference addition into separate functions for startup application and tests. |
Comments suppressed due to low confidence (1)
src/Moryx.Cli.Commands/AddStep.cs:47
- [nitpick] Consider renaming the loop variable 'project' to 'projectFile' for improved clarity, as it represents a project file path.
ProjectFileManipulation.AddProjectReference(applicationProjectFile, project);
1nf0rmagician
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.