You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
the idea of this PR is taken from #2265.
Having the governance system accept P2SH proposals is a nice addition since, for example, the work of a team can be paid in a single multisig address.
P2SH proposals will be enabled after v6.0 and is not backward compatible: in particular with the current implementation a v6 node will relay a p2sh proposal even to non-v6 nodes (and will lead to non v6 nodes banning the v6 node).
Since v6.0 will be a huge mandatory update I don't think it will be an issue
Ready for review: last commit is a bit out of scope and adds CheckString() in IsWellFormed() (It was a waste of time opening another PR just for that line)
There is already a dedicated validateURL() helper in utilstrencodings, so it may be worth considering URL-specific validation here instead of using the generic SanitizeString() check.
The added functional test covering the P2SH proposal flow is useful, but I would also recommend adding regression coverage for valid URLs containing query parameters and fragments.
I don't see a consensus-level issue with the core P2SH payout change itself, but I think the URL validation behavior should be clarified or fixed before this PR is approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the idea of this PR is taken from #2265.
Having the governance system accept P2SH proposals is a nice addition since, for example, the work of a team can be paid in a single multisig address.
P2SH proposals will be enabled after v6.0 and is not backward compatible: in particular with the current implementation a v6 node will relay a p2sh proposal even to non-v6 nodes (and will lead to non v6 nodes banning the v6 node).
Since v6.0 will be a huge mandatory update I don't think it will be an issue