[PoC] Inspect OIDC claims for an external fork PR - #154
Closed
fritznoff wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
This draft PR was created purely for authorized security testing of GitHub Actions OIDC permissions on external fork pull requests. No AWS role was assumed, no credentials or JWTs were printed, and no private image was accessed. The test is complete and the PR will not be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before / After
Before: we do not have direct evidence showing which OIDC claims GitHub issues when this public repository runs a workflow from an external fork PR.
After: one fork-only diagnostic step requests an OIDC token and prints only selected non-secret claims. It never prints the JWT.
Why this approach
This is the smallest test that validates the GitHub side of the trust boundary without assuming an AWS role or accessing ECR. Using the production ECR role was rejected because a successful test would grant real private-image access.
Demo
After a maintainer approves the fork workflow if required, inspect the
PoC — inspect fork OIDC claimsstep. The relevant expected values are:Out of scope
How to test
Lint and Test Chartsworkflow.PoC — inspect fork OIDC claims.Manual QA steps
Confirm the log contains decoded claim fields but contains neither a three-part JWT nor AWS access credentials.
Risks / notes
This draft PR is a temporary security diagnostic and should be closed after evidence is captured. It changes no chart files, so existing AWS/ECR steps remain skipped.