Skip to content

⚠️ [maestrod] Remove public AWS account metadata (include in next real maestrod change!) - #155

Closed
fritznoff wants to merge 2 commits into
masterfrom
fridtjof/remove-public-aws-account-id
Closed

⚠️ [maestrod] Remove public AWS account metadata (include in next real maestrod change!)#155
fritznoff wants to merge 2 commits into
masterfrom
fridtjof/remove-public-aws-account-id

Conversation

@fritznoff

@fritznoff fritznoff commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Important

Landed in #156

Summary

  • Removes the hard-coded AWS account ID and private ECR hostname from public CI files.
  • Reuses the registry URL already returned by the existing ECR login action.
  • Masks the AWS account ID in workflow logs.
  • Replaces internal registry and Secret names in public documentation with clear examples.
  • Keeps private-image CI limited to same-repository PRs; fork PRs skip that install check.

Validation

  • actionlint .github/workflows/lint-test.yaml
  • helm lint with both Maestrod CI values files
  • Rendered both CI configurations with a dynamic registry override
  • Regenerated the Maestrod README with helm-docs

@fritznoff
fritznoff marked this pull request as draft July 31, 2026 16:12
@fritznoff

fritznoff commented Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

Important

Holding off on merging this until the next real change on the maestrod chart is necessary so as to avoid a rollout to prod on a Friday night.
Should be included in the next update though. More context on this Slack thread.

@fritznoff fritznoff changed the title [maestrod] Remove public AWS account metadata ⚠️ [maestrod] Remove public AWS account metadata Jul 31, 2026
@fritznoff fritznoff changed the title ⚠️ [maestrod] Remove public AWS account metadata ⚠️ [maestrod] Remove public AWS account metadata (include in next real maestrod change!) Jul 31, 2026
fritznoff added a commit that referenced this pull request Aug 5, 2026
## Summary

- Updates maestrod helm chart to appVersion `1.3.0` (chart version
`0.6.5`).
- Includes #155: removes hard-coded AWS account ID/private ECR hostname
from public CI files and docs, masks the AWS account ID in workflow
logs, and keeps private-image CI limited to same-repository PRs.

## Validation

- `helm lint charts/maestrod`
- `helm-docs --chart-search-root charts/maestrod`
- `helm schema` (values.schema.json regenerated, no diff)
@fritznoff

Copy link
Copy Markdown
Contributor Author

Landed in #156, closing.

@fritznoff fritznoff closed this Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant