Skip to content

Conversation

@vilikili
Copy link

@vilikili vilikili commented Dec 29, 2025

Currently the mannequin takes damage as if the difficulty was set to normal.

This PR fixes that by checking the level difficulty & applying the correct amount of damage.

@vilikili vilikili requested a review from a team as a code owner December 29, 2025 03:19
@github-project-automation github-project-automation bot moved this to Awaiting review in Paper PR Queue Dec 29, 2025
@Owen1212055
Copy link
Member

Is there an mc bug report for this? I'm not sure about deviating from vanilla here and this doesn't quite make sense.

@CJendantix
Copy link

Is there an mc bug report for this? I'm not sure about deviating from vanilla here and this doesn't quite make sense.

https://report.bugs.mojang.com/servicedesk/customer/portal/2/MC-305338

@mbax
Copy link
Contributor

mbax commented Dec 29, 2025

@Owen1212055
Copy link
Member

Thank you for the PR!

However, I will be closing this PR as invalid.

In general, this damage scaling seems to only be applicable to Player entities and not mannequins. It doesn't really make sense for damage scaling to be applied to these entity types, as additionally these checks also in some cases check for Players (WHEN_CAUSED_BY_LIVING_NON_PLAYER) which doesnt really make sense now anymore.

If the bug report is accepted, this decision could be revisited.

@Owen1212055 Owen1212055 closed this Jan 4, 2026
@github-project-automation github-project-automation bot moved this from Awaiting review to Closed in Paper PR Queue Jan 4, 2026
@Owen1212055 Owen1212055 added the resolution: invalid Issue or Request has no basis. label Jan 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

resolution: invalid Issue or Request has no basis.

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

4 participants